882:
923:
861:
48:
420:
that should be cleared before running further. For the http example you gave, I think it will be kept as is, just renamed to url-status. I don't know if the template will then give an error due to the incorrect parameter, but I think it is an ok way to handle it for this run, unless there is already
461:
The red warning message should be suppressed immediately, until this bot has completed its run, then re-enable. We have over 2 million archive links (less in CS1|2), it is unnecessary to upset the community with a large volume red warning messages. --
658:
showed a problem with corruption in some cases, but that has been fixed now. More unit testing is probably a good idea. Even if those constructions should be rare, it's better to make only careful changes than to have to find the corruption later.
758:
Yep, could be. If that becomes a problem, we can worry about it later. Two out of 102 pages processed is a hair over 2% (this is a very small sample). Are you going to block this BRFA because this task skips templates with html
326:
I take that "dead-url=yes" will be replaced as "url-status=dead" and similar? Regarding
Ivanvector's point, it seems like this bot is meant to update the templates to bring them in line with the new template parameters.
421:
now time and interest to decide that all illegal values should be rewritten according to some rule. These errors I hope would be only few, so main prio is to make sure that the bot doesn't destroy anything unknowingly.
435:
Correct; parameter name changes but parameter value is retained (it was wrong before the bot fix and will likely be wrong after the bot fix). The bot will only change known good parameter values to the new parameter
620:. I think the code will not see the comment as "blank", so an empty parameter having a comment should be kept. I think this behavior, apart from editing within comments, is as intended. It should be properly tested.
709:
655:
604:
417:
643:
291:
238:
994:
607:
if you have worries or just want to confirm proper behavior. Test cases can be made up, but if you have actual example pages/references, that may be even better.
256:
650:, which is equally illegal. This should be a good first step, those errors can be left for manual evaluation or be the target of another bot run later.
152:
546:
389:
I've done a manual search-and-replace on a handful of pages and can confirm that this change does resolve the new errors regarding deprecation of
140:
21:
635:
and is not part of the task. The slight deviation from this truth is that any empty parameter will be removed, this may remove an empty
631:
parameters are kept. This may introduce duplicate parameters with conflicting value, but I think that's ok for a first step. In effect
164:
368:
this bot task could not have been run before the implementation of today's changes because the cs1|2 module suite did not know about
677:
Whenever the bots detect an html comment inside a cs1|2 template, it will skip that template; fixes will not be made. This task is
499:
336:
406:
316:
776:
Honest question: how difficult would it be to hide wikicomments inside a template, make the change, restore the wikicomment? --
87:
865:
Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.
889:
528:
158:
82:
393:. FWIW. Although I don't know how it will respond to errors where someone has put the URL itself as the parameter (i.e.
912:
848:
767:
726:
536:
516:
444:
380:
146:
134:
603:
I'm not responsible for the code, but I had a look at it and may be able to answer. Please add suggested test cases
809:: Please ensure that the bot correctly processes parameter values that are invalid due to upper-case letters, e.g.
246:
117:
554:
102:
979:
937:
916:
908:
875:
852:
844:
831:
791:
771:
763:
753:
735:
730:
722:
668:
598:
558:
547:
Knowledge (XXG):Administrators' noticeboard#Proposal to overturn the mass change made to Module:Citation/CS1
540:
532:
520:
512:
503:
495:
477:
448:
440:
430:
411:
384:
376:
340:
332:
321:
129:
956:
738:, wikicomments inside templates are common (usually left by old bots), could result in a lot skipped. --
40:
224:
827:
550:
306:
has caused ref errors to generate all over the project, which several editors are upset about (see
303:
97:
567:
92:
933:
871:
594:
491:
328:
975:
664:
426:
77:
17:
784:
746:
470:
970:
in response to the questions. This was after trial permission but before the trial report.
401:
311:
483:
307:
893:
823:
988:
929:
867:
612:
There seems to be no special treatment of comments. It should be retained as is, but
590:
487:
308:
WP:AN#Is there a semi-automated tool that could fix these annoying "Cite Web" errors?
274:
971:
660:
422:
58:
310:). If this bot is a step in repairing those errors, please expedite this request.
247:
Help talk:Citation Style 1#update to the cs1|2 module suite after 2 September 2019
966:
For the record, the bot behavior for "html comments" and "case sensitivity" were
577:
param exists already but has an invalid value, does the bot change it in any way?
777:
739:
549:
has concluded as the closed discussion may effect the usefulness of this bot. -
463:
233:
897:
570:
within citations? If not at all, what do you think it should do, if anything?
508:
Not a function of this bot task and already done in the cs1|2 module suite.
646:
are clear if you know how to interpret them. Your example will result in
949:
The above discussion is preserved as an archive of the debate.
396:
292:
User:Monkbot/task 16: remove replace deprecated dead-url params
239:
User:Monkbot/task 16: remove replace deprecated dead-url params
955:
To request review of this BRFA, please start a new section at
194:
39:
To request review of this BRFA, please start a new section at
639:
parameter, but not one with another illegal or legal value.
967:
815:
714:
416:
I reviewed the given source code and I think there are
182:
176:
170:
112:
107:
72:
490:
would be where that suggestion has been made already.
482:
Sure, but that's not really a question for this page;
836:
As far as the bot is concerned, case of keywords in
995:Approved Knowledge (XXG) bot requests for approval
527:I have manually run the bot task on 50 pages; see
244:Links to relevant discussions (where appropriate):
708:Testcases described here and at Editor JAGulin's
545:I recommend that this bot not be approved until
33:The following discussion is an archived debate.
892:. Nothing untoward noticed. The task skipped
623:As of now, this change is all about replacing
8:
701:so the bot cannot know what to do with it.
257:Category:CS1 errors: deprecated parameters
901:
837:
698:
690:
686:
682:
394:
390:
369:
361:
357:
352:
348:
212:
208:
204:
7:
685:or any other periodical parameter.
262:Estimated number of pages affected:
193:13:03, Tuesday, September 3, 2019 (
633:website parameters are not touched
28:
249:and discussion linked from there
218:Automatic, Supervised, or Manual:
45:The result of the discussion was
921:
880:
859:
46:
614:if the comment itself mentions
818:Chief of the Air Staff (India)
255:as often as required to clear
1:
980:10:27, 7 September 2019 (UTC)
938:15:19, 5 September 2019 (UTC)
917:14:21, 5 September 2019 (UTC)
890:Special:Contributions/Monkbot
876:11:08, 5 September 2019 (UTC)
853:13:11, 5 September 2019 (UTC)
832:17:48, 4 September 2019 (UTC)
792:14:39, 5 September 2019 (UTC)
772:14:31, 5 September 2019 (UTC)
754:14:24, 5 September 2019 (UTC)
731:13:11, 5 September 2019 (UTC)
669:06:29, 4 September 2019 (UTC)
599:22:04, 3 September 2019 (UTC)
568:<!-- html comments --: -->
559:15:23, 3 September 2019 (UTC)
541:15:07, 3 September 2019 (UTC)
529:Special:Contributions/Monkbot
521:13:11, 5 September 2019 (UTC)
504:14:59, 3 September 2019 (UTC)
478:14:51, 3 September 2019 (UTC)
449:13:11, 5 September 2019 (UTC)
431:20:24, 3 September 2019 (UTC)
412:14:41, 3 September 2019 (UTC)
385:14:20, 3 September 2019 (UTC)
341:13:50, 3 September 2019 (UTC)
322:13:43, 3 September 2019 (UTC)
900:because of html comments in
618:it will probably be modified
397:https://www.offline.website/
270:all that cs1|2 categorizes
1011:
697:was an invalid value for
566:How does your bot handle
952:Please do not modify it.
584:or other invalid values?
36:Please do not modify it.
563:A couple of questions:
211:in cs1|2 template with
302:It seems a change to
290:details available at
22:Requests for approval
904:(DASHBot signature).
691:|url-status=May 2016
225:Programming language
18:Knowledge (XXG):Bots
689:will be changed to
648:url-status=May 2016
304:Module:Citation/CS1
275:Exclusion compliant
580:What happens with
201:Function overview:
909:Trappist the monk
845:Trappist the monk
764:Trappist the monk
736:Trappist the monk
723:Trappist the monk
687:|deadurl=May 2016
642:The steps in the
582:|deadurl=May 2016
533:Trappist the monk
513:Trappist the monk
441:Trappist the monk
377:Trappist the monk
288:Function details:
130:Trappist the monk
1002:
954:
925:
924:
903:
884:
883:
863:
862:
839:
821:
816:Old revision of
812:
789:
782:
751:
744:
717:
700:
696:
692:
688:
684:
583:
576:
475:
468:
399:
392:
371:
363:
362:|url-status=live
359:
354:
353:|url-status=dead
350:
214:
210:
206:
187:
186:
50:
49:
38:
1010:
1009:
1005:
1004:
1003:
1001:
1000:
999:
985:
984:
963:
950:
922:
886:Trial complete.
881:
860:
814:
810:
785:
778:
747:
740:
713:
694:
627:, and existing
581:
574:
471:
464:
409:
319:
299:
264:many upon many
253:Edit period(s):
132:
128:
123:
62:
47:
34:
26:
25:
24:
12:
11:
5:
1008:
1006:
998:
997:
987:
986:
983:
982:
962:
961:
945:
944:
943:
942:
941:
940:
905:
894:Ad valorem tax
857:
856:
855:
841:
804:
803:
802:
801:
800:
799:
798:
797:
796:
795:
794:
760:
719:
704:
703:
702:
680:
673:
672:
671:
652:
651:
640:
621:
609:
608:
586:
585:
578:
571:
561:
551:Knowledgekid87
543:
525:
524:
523:
509:
506:
459:
458:
457:
456:
455:
454:
453:
452:
451:
437:
405:
373:
366:
365:
364:
355:
324:
315:
298:
295:
122:
121:
115:
110:
105:
100:
95:
90:
85:
80:
75:
73:Approved BRFAs
70:
63:
61:
56:
55:
54:
29:
27:
15:
14:
13:
10:
9:
6:
4:
3:
2:
1007:
996:
993:
992:
990:
981:
977:
973:
969:
965:
964:
960:
958:
953:
947:
946:
939:
935:
931:
928:
920:
919:
918:
914:
910:
906:
902:|archivedate=
899:
895:
891:
887:
879:
878:
877:
873:
869:
866:
858:
854:
850:
846:
842:
835:
834:
833:
829:
825:
820:
819:
808:
805:
793:
790:
788:
783:
781:
775:
774:
773:
769:
765:
761:
757:
756:
755:
752:
750:
745:
743:
737:
734:
733:
732:
728:
724:
720:
716:
711:
707:
706:
705:
678:
676:
675:
674:
670:
666:
662:
657:
656:My test cases
654:
653:
649:
645:
641:
638:
634:
630:
626:
622:
619:
617:
611:
610:
606:
602:
601:
600:
596:
592:
588:
587:
579:
572:
569:
565:
564:
562:
560:
556:
552:
548:
544:
542:
538:
534:
530:
526:
522:
518:
514:
510:
507:
505:
501:
500:contributions
497:
493:
492:Jo-Jo Eumerus
489:
488:Help talk:CS1
485:
481:
480:
479:
476:
474:
469:
467:
460:
450:
446:
442:
438:
434:
433:
432:
428:
424:
419:
415:
414:
413:
408:
403:
398:
388:
387:
386:
382:
378:
374:
367:
356:
349:|dead-url=yes
347:
346:
344:
343:
342:
338:
337:contributions
334:
330:
329:Jo-Jo Eumerus
325:
323:
318:
313:
309:
305:
301:
300:
296:
294:
293:
289:
285:
283:
280:
277:
276:
271:
269:
268:Namespace(s):
265:
263:
259:
258:
254:
250:
248:
245:
241:
240:
237:
235:
230:
228:
226:
221:
219:
215:
202:
198:
196:
192:
188:
184:
181:
178:
175:
172:
169:
166:
163:
160:
157:
154:
151:
148:
145:
142:
139:
136:
131:
127:
119:
116:
114:
111:
109:
106:
104:
101:
99:
96:
94:
91:
89:
86:
84:
81:
79:
76:
74:
71:
69:
65:
64:
60:
57:
53:
44:
42:
37:
31:
30:
23:
19:
951:
948:
926:
885:
864:
822:. Thanks. –
817:
811:|dead-url=No
806:
786:
779:
748:
741:
712:are show in
647:
636:
632:
628:
624:
615:
613:
472:
465:
370:|url-status=
358:|dead-url=no
287:
286:
281:
278:
273:
272:
267:
266:
261:
260:
252:
251:
243:
242:
232:
231:
223:
222:
217:
216:
213:|url-status=
200:
199:
190:
189:
179:
173:
167:
161:
155:
149:
143:
137:
125:
124:
67:
51:
35:
32:
888:results at
840:is ignored.
644:description
234:Source code
191:Time filed:
898:Ad hominem
838:|dead-url=
710:test cases
699:|dead-url=
629:url-status
418:test cases
402:Ivanvector
395:|dead-url=
391:|dead-url=
312:Ivanvector
297:Discussion
236:available:
220:automatic
205:|dead-url=
183:ANI search
177:rights log
165:page moves
153:edit count
113:rights log
103:page moves
59:Monkbot 16
927:Approved.
824:Jonesey95
759:comments?
715:this diff
683:|website=
575:|website=
209:|deadurl=
203:replaces
171:block log
126:Operator:
108:block log
52:Approved.
989:Category
968:modified
930:Primefac
868:Primefac
813:, as in
695:May 2016
625:dead-url
616:dead-url
591:Mathglot
589:Thanks,
279:(Yes/No)
229:awb c++
141:contribs
83:contribs
20: |
972:JAGulin
957:WT:BRFA
807:Comment
661:JAGulin
637:website
573:If the
436:values.
423:JAGulin
41:WT:BRFA
681:about
780:Green
742:Green
484:WP:AN
466:Green
407:Edits
345:Yes:
317:Edits
88:count
16:<
976:talk
934:talk
913:talk
896:and
872:talk
849:talk
828:talk
768:talk
727:talk
665:talk
605:here
595:talk
555:talk
537:talk
517:talk
496:talk
486:and
445:talk
427:talk
381:talk
333:talk
284:yes
227:(s):
207:and
159:logs
135:talk
118:flag
98:logs
78:talk
68:BRFA
679:not
400:).
195:UTC
147:SUL
93:SUL
991::
978:)
936:)
915:)
874:)
851:)
830:)
770:)
729:)
693:;
667:)
597:)
557:)
539:)
531:.—
519:)
502:)
498:,
447:)
429:)
410:)
404:(/
383:)
360:→
351:→
339:)
335:,
320:)
314:(/
197:)
974:(
959:.
932:(
911:(
907:—
870:(
847:(
843:—
826:(
787:C
766:(
762:—
749:C
725:(
721:—
718:.
663:(
593:(
553:(
535:(
515:(
511:—
494:(
473:C
443:(
439:—
425:(
379:(
375:—
372:.
331:(
282::
185:)
180:·
174:·
168:·
162:·
156:·
150:·
144:·
138:·
133:(
120:)
66:(
43:.
Text is available under the Creative Commons Attribution-ShareAlike License. Additional terms may apply.